layerdisplay icon indicating copy to clipboard operation
layerdisplay copied to clipboard

[Feature Request] Python 3 Compatibility

Open Trashwarez opened this issue 4 years ago • 3 comments

Trashwarez avatar Dec 02 '20 17:12 Trashwarez

I wonder if any progress is happening here. Both contributors have activity this year in other repositories.

OldCurmudgeon3DP avatar Mar 31 '21 13:03 OldCurmudgeon3DP

I don't even know where to start. I learned python for this and forgot it all 😮 I don't know much about the python ecosystem nor do I have a dev environment setup

prgmatic avatar Aug 04 '21 11:08 prgmatic

Hello, all;

I've created a fork and a branch to work on porting this to Python 3+. This port is now working in OctoPrint 1.6.1 on Python 3.6.0 on my pi system. I'd like to get some feedback from others who may want to try this on Python 2.7.x and other 3.x before I submit a pull request to the developer.

(I'm having some problems getting back to my old Python 2.7.x venv but maybe I can get that all worked out shortly and do some testing in 2.7.x again myself. ;-) If not, it may make sense to just change the compatibility property string to ">=3,<4" and just say that versions up through 0.4.3 only work on Python 2.7.x and "this version" only works on Python 3 and above. Don't know. That's something for the developer to think about too.)

In my port, I've bumped the version to 0.5.0 to keep it separate from the 0.4.x version by @chatrat12. If it seems to be working correctly, the developer / contributor would be advised to change the version to whatever he or she desires.

If someone wants to try the ported version, use Plugin Manager -> + Get More -> "... from URL" with an address of https://github.com/dandreat/layerdisplay/archive/py3port.zip BTW, you can always just use the same URL, download, and unzip it locally to have a look at the files if you want to make sure there's nothing malicious in there.

Anyway, I'm happy to have this plugin back again! I really missed it! I hope this is helpful to others as well.

Cheers,

Dave Andreatta

dandreat avatar Sep 07 '21 12:09 dandreat