impressionist icon indicating copy to clipboard operation
impressionist copied to clipboard

test directory README doesn't work with Rails 3.2, Ruby 1.9.2

Open cobbr2 opened this issue 11 years ago • 2 comments

The step rails g impressionist called out in tests/README fails, with a Usage message from rails new.

When I replace with 'rails new impressionist', I get

Invalid application name impressionist, constant Impressionist is already in use. Please choose another application name.

If I ignore the instructions entirely and go straight to the db: steps, I get:

rake aborted!
Don't know how to build task 'db:migrate'

What's the correct way to set up to test this gem?

cobbr2 avatar Sep 05 '14 21:09 cobbr2

My apologies. I'm apparently using Rails 4.1.5, having followed the instructions and done a bundle install first. However, even after figuring out that I should reclone and rebuild using bundle install --gemfile=gemfiles/rails32.gemfile if I wanted to try Rails 3.2, I get the same behavior. I'll note that these are the same instructions as in the main project README.md.

cobbr2 avatar Sep 05 '14 22:09 cobbr2

I've found the issue and will prepare a clean PR shortly. The core is that the first line of the instructions should be:

cd tests/test_app

Also, the test_app Gemfile needs a simple patch to restrict it to rspec-rails ~>2.14.0 .

Apparently, the "nothing else" part of the instructions also includes do not run bundle install at the top directory.

cobbr2 avatar Sep 08 '14 17:09 cobbr2