filedrop-svelte icon indicating copy to clipboard operation
filedrop-svelte copied to clipboard

Fixed dragEnter and dragLeave being fired on child elements

Open IsAvaible opened this issue 3 years ago • 1 comments

This is a solution for Issue 6, that works by keeping track of the number of times dragEnter and dragLeave were fired, and only dispatches an event when the counter reaches zero (implementing https://stackoverflow.com/a/21002544).

IsAvaible avatar May 22 '22 08:05 IsAvaible

awesome, thanks! I'll look it over sometime this week. Hopefully tomorrow but my schedule is slammed at the moment.

The fact that I never got around to writing tests for this package is catching up with me.

chanced avatar May 22 '22 13:05 chanced

Can i contribute to this repo by implementing the fix? Right now i have the implementation in my codebase, but it would be awesome if it was a part of the package

Edit: hmm realizing, maybe it's better to actually leave the events as is, for less opinionation

segefjord avatar Apr 03 '23 09:04 segefjord