Chance

Results 101 comments of Chance

Yea, this a tough one. I'm not sure what the right call is. Inversely, `.as_str().len()` gets the byte count. Lets stew on `len`, it doesn't need to be decided now.

I'm game for removing it. I think that's the answer.`Path` setting the precedent seals the deal for me.

Even if we end up adding it back, I think it can be added after it goes through the deprecation cycle. By that point, it'll have been at least 2...

The behavior is consistent on each run of the test. It requires getting to the end and encountering my faulty logic before it manifests. https://github.com/chanced/grill/blob/f48725f562b8972a92156a29b620d7406e4a0ce3/grill-core/src/source/walk/to.rs

> Hmm, interesting, Does it behave in some abnormal way otherwise? Or is it just the debugger that's throwing a fit? It behaves normally

Damnit, I really regret pushing `0.7`. Agreed that it should have been bundled. We can cut a `0.8` in short order i think. I doubt many will have picked up...

Great changes and good catch! I kinda regret pushing the last release in haste - ah well. I don't think we will be touching errors after this release so hopefully...

This is breaking but probably pretty uncommon. A type could implement `Deref` but not `Into` ```rust struct X; impl std::ops::Deref for X { type Target = str; fn deref(&self) ->...

> make diagnostic::Label::new private This one needs to be public in order for users to implement `Diagnostic` properly. Users can bring their own errors for `Assign` and `Resolve` but they...

I dont necessarily expect it - I doubt anyone is implementing `Assign` and `Resolve` for custom languages or data structures - but it is possible and in an effort to...