TakWeb
TakWeb copied to clipboard
chaitu236
Bug: Notation Layout and Move Flashing
The notation window currently displays the PTN in a reasonably functional way. However some features are provisionary at the moment. The application of moves will flash the board and cause the textures to vanish for a brief moment. Whenever a player makes a move, this will occure too. Also the width of the notation entries will vary depending on the currently displayed move, as well as the size of various entries (Firefox). I have fixes for both in my current Fork, which I can make into a mergable patch on request. See treffnonx.github.io/TakWeb for reference.
These fixes will also make the disabled rendering during move updates obsolete, as the reorganization of pieces does not require an interruption in rendering.
Ah yes, I noticed you fixed it in your branch and was planning to pull your changes. I'll do that in a week when I'm free.
Since I have modulazired index.html into different files, I suspect it will be rather tough to pull without me reintegrating it into the master branch first. Best thing would probably be, if you told me if you want all the notification modifications, or just parts of it. I will then integrate that into the master and start a pull request.
I'll probably modularize also before taking your changes. I'll look at your modularization changes and notification changes before deciding what to take.
I've been looking into compression tools to fold the modularized files into one again, when deploying it on a server. I have not found a tool I like yet. Maybe you will have more success.
I'll take your "Notation Layout and Move Flashing" changes and then modularize my own way. I don't need the notification modifications right now. Could you make a patch against the master branch?
I can make a patch, but I am not home currently, and won't be back til Monday night. Don't wait for me with anyother changes, I'll make it work with whatever is the current state then.