xelb icon indicating copy to clipboard operation
xelb copied to clipboard

Make use of offset argument to improve performance

Open wasamasa opened this issue 2 years ago • 5 comments

This builds upon #2 which did most of the work. For some reason the original PR did hardcode the offset to 0 and instead created copies of the array with an increasing offset instead.

Before: Initiating a X connection with xcb:connect took between 2.4 and 2.9s

After: Initiating a X connection with xcb:connect now takes 0.31 to 0.33s

wasamasa avatar May 28 '23 20:05 wasamasa

Hi,

I deployed EXWM built on this branch via my custom channel in Guix. EXWM works fine and seems to start a few seconds faster.

Thank you for maintaining this great little library!

Kind regards Felix Lechner

lechner avatar May 30 '23 03:05 lechner

Hi,

This PR has another positive side effect. Aside from the speed up, it fixed an annoying problem I've had with my multi-head setup for a while.

Previously, my third monitor would only come up about sixty percent of the time, although I'm not sure how to explain that interaction with xrandr in my init.el. That's now fixed!

Kind regards Felix

lechner avatar Jun 27 '23 15:06 lechner

@Stebalien Have you seen this patch? What do you think about it?

minad avatar Jan 14 '24 10:01 minad

This seems completely reasonable. (and @wasamasa has his papers in order, unless I'm mistaken).

Stebalien avatar Jan 14 '24 16:01 Stebalien

But the fact that emacs-exwm/xelb isn't a fork is really annoying when it comes to porting PRs...

Stebalien avatar Jan 14 '24 17:01 Stebalien