cgreen icon indicating copy to clipboard operation
cgreen copied to clipboard

add_tests - is it working, needed? Why no context-version?

Open thoni56 opened this issue 10 years ago • 1 comments

I tried to use add_tests(), note the plural. It seems not to be working. Anyone know if it's working?

Is there a compelling reason to have this duplicated feature? (As you can add your tests one by one, I'd consider this a duplication.)

One option is to remove it. Else we need to fix it so that it works, and has a "with_context" counterpart. (But also see #12 for my view on "with_context".)

thoni56 avatar Sep 29 '15 20:09 thoni56

I looked at the git blame for the header and source files that contain the declarations and implementation of add_tests, but those were just moving the existing function around. Unfortunately, svn didn't track changes across the rename of unit.c, so I don't know why add_tests was added without spelunking into the svn logs of revisions before the file renaming.

Is add_tests(...) useful for passing along variadic expansion of suites/tests from a tool-writing perspective? If so, then we should fix it and add a context variant of the API. If not, I can ask at previous companies I've worked with if they're using add_tests -- we can deprecate/remove it if they aren't.

matthargett avatar Sep 30 '15 21:09 matthargett