babel-plugin-template-html-minifier icon indicating copy to clipboard operation
babel-plugin-template-html-minifier copied to clipboard

Published 20 hours ago • verified publisher icon cfware

When using lit-element or lit-html @event syntax, don't use sortAttributes in htmlMinifier

Open moderndeveloperllc opened this issue 5 years ago • 3 comments

This is not an issue with your library, but you might want to put it in the hint for htmlMinifier. Using @event-style syntax in elements of your render() templates can cause issues if you use sortAttributes - https://github.com/kangax/html-minifier/issues/1057. Basically the attributes get sorted, but the replacement strings don't.

moderndeveloperllc avatar Jan 13 '20 21:01 moderndeveloperllc

I would not object to a PR adding a note to the README along with the other notes about lit-html usage in the htmlMinifier section.

CC @LarsDenBakker not sure if this is something open-wc is aware of?

coreyfarrell avatar Jan 13 '20 22:01 coreyfarrell

No I never encountered this before

LarsDenBakker avatar Jan 14 '20 07:01 LarsDenBakker

Reading into this more thoroughly, this does seem like a plausible issue.

LarsDenBakker avatar Feb 02 '20 09:02 LarsDenBakker