openshift-routes icon indicating copy to clipboard operation
openshift-routes copied to clipboard

Make it possible to install openshift-routes in a different namespace than "cert-manager"

Open maelvls opened this issue 2 years ago • 3 comments

This is a continuation of https://github.com/cert-manager/openshift-routes/pull/32.

maelvls avatar Sep 15 '23 14:09 maelvls

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from maelvls. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

jetstack-bot avatar Sep 15 '23 14:09 jetstack-bot

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.

:memo: Please follow instructions in the contributing guide to update your commits with the DCO

Full details of the Developer Certificate of Origin can be found at developercertificate.org.

The list of commits missing DCO signoff:

  • 765e6e0 make it possible to install to a different namespace
  • bd7fc5b deploy/static: use '${RELEASED_VERSION}' instead of '$RELEASED_VERSION'
  • e7057ab deploy/static: introduce '${NAMESPACE}'
  • effea4c deploy/static: use kube-system as the default election namespace

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

jetstack-bot avatar Sep 15 '23 15:09 jetstack-bot

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jetstack-bot avatar Oct 11 '23 09:10 jetstack-bot

@maelvls: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cert-manager-openshift-routes-smoke 457b4474c737bbbc0edf5cb728724e205456753d link true /test pull-cert-manager-openshift-routes-smoke

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

cert-manager-prow[bot] avatar Jul 15 '24 12:07 cert-manager-prow[bot]

Closing as I wasn't able to find the time to finish this. Please feel free to take over!

maelvls avatar Jul 19 '24 10:07 maelvls