openshift-routes icon indicating copy to clipboard operation
openshift-routes copied to clipboard

Annotation generates CertificatesRequests repeatedly until blocked by letsencrypt

Open lmiranda opened this issue 3 years ago • 1 comments

The following annotation generates CertificatesRequests in a row and Lets Encrypt block it for requesting too many certificates for the same domain. cert-manager.io/duration: 2160h cert-manager.io/issuer-kind: ClusterIssuer cert-manager.io/issuer-name: letsencrypt-clusterissuer cert-manager.io/renew-before: 360h

lmiranda avatar Aug 22 '22 18:08 lmiranda

Hi.

This issue is probably caused by the "limited" renewal logic in openshift-routes. Right now, there isn't any error backoff mechanism in place, meaning that I would not recommend using openshift-routes with Let's Encrypt or any service that has a rate limit.

In https://github.com/cert-manager/openshift-routes/issues/34#issue-1821609791, similar concerns were raised: openshift-routes re-implements cert-manager's renewal mechanism, and I think openshift-routes should have gone simpler by creating Certificate resources and letting cert-manager handle retrials and such rather than re-implementing the whole issuance logic.

Fixing this issue will take work as I think we need to start creating Certificate resources rather than hurting ourselves with reimplenting the certificate renewal logic.

maelvls avatar Dec 15 '23 14:12 maelvls