Added tolerations,nodeSelector,affinity,topologySpreadConstraints

[saydulaev]

When i tried to deploy a helm chart to tainted nodes i figured out that templates didn't contain the Kubernetes scheduler fields like:

• tolerations
• nodeSelector
• affinity
• topologySpreadConstraints

Added it to deployment and daemonset.

[jetstack-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign jakexks for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[jetstack-bot]

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.

:memo: Please follow instructions in the contributing guide to update your commits with the DCO

Full details of the Developer Certificate of Origin can be found at developercertificate.org.

The list of commits missing DCO signoff:

• 44cdfc0 Added tolerations,nodeSelector,affinity,topologySpreadConstraints

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[jetstack-bot]

Hi @saydulaev. Thanks for your PR.

I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jetstack-bot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[SgtCoDFish]

Hey, thanks for raising this - really sorry its taken so long for anyone to look at it!

If you're able to fix the merge conflict I'd be happy to review. Again, sorry about the delay!

[SgtCoDFish]

/ok-to-test

[maelvls]

Hey, do you mind if I rebase your changes and fix the conflict?

I'll go ahead and add the DCO line to your commit message:

Signed-off-by: Ruslan Saydulaev <[email protected]>

[maelvls]

Test is failing, looks like a flake:

camanager_test.go:62: 
     Error Trace:	/home/prow/go/src/github.com/cert-manager/csi-driver-spiffe/internal/csi/driver/camanager_test.go:62
     Error:      	updateRootCAFilesFn() was not called in time
     Test:       	Test_manageCAFiles

/retest

[cert-manager-prow[bot]]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SgtCoDFish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ~~OWNERS~~ [SgtCoDFish]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment