circuit icon indicating copy to clipboard operation
circuit copied to clipboard

StatSender interface signature has changed

Open 7ail opened this issue 3 years ago • 1 comments

Hi there,

Tried configuring the StatSender in statsdmetrics.CommandFactory{} and realised the statsdmetrics.StatSender interface no longer matches the StatSender interface in go-statsd-client.

https://github.com/cactus/go-statsd-client/blob/6348b56a993b50ba0d50dd9c3515c79dab38d639/statsd/client.go#L18-L28

Seems like they've introduced a new variadic parameter for tags at the end

7ail avatar Jun 30 '22 03:06 7ail

Thanks for the update. I don't think I can change this API to match because it would be a breaking change for users of the library. I recommend maybe a comment at the interface with a recommendation that people implement a custom metrics collector.

We have one for prometheus here. If you want to make one for statsd with the new API, you can reference it and I'll update the docs to point to it as an alternative.

cep21 avatar Jul 01 '22 00:07 cep21

Will close as wontfix for v3 since we cannot break people's code, but will address in v4 here: #115

cep21 avatar Sep 06 '22 16:09 cep21