opencensus-go-exporter-stackdriver icon indicating copy to clipboard operation
opencensus-go-exporter-stackdriver copied to clipboard

skip exporting points with no value due to prometheus staleness markers

Open kwiesmueller opened this issue 3 years ago • 4 comments

This fixes cases where a staleness marker causes errors like:

rpc error: code = InvalidArgument desc = One or more TimeSeries could not be written: Field timeSeries[94].points[0].value had an invalid value: A point has an unrecognized value type.; Field timeSeries[95].points[0].value had an invalid value: A point has an unrecognized value type.\nerror details: name = Unknown  desc = total_point_count:155 success_point_count:153 errors:{status:{code:3} point_count:2}

By properly dropping any point that is a staleness marker instead of exporting them without a value.

The fixed issue was introduced with https://github.com/census-ecosystem/opencensus-go-exporter-stackdriver/pull/300. The bug should not cause any data loss, it just causes error logs and an increase in exporter error metrics.

kwiesmueller avatar Aug 09 '22 18:08 kwiesmueller

/assign @dashpole

kwiesmueller avatar Aug 09 '22 18:08 kwiesmueller

Actually, my test just failed as we're now sending timeseries with no points which is also not okay :-/ Needs more work.

kwiesmueller avatar Aug 09 '22 18:08 kwiesmueller

Alright, works now in our collector. PTAL.

kwiesmueller avatar Aug 09 '22 19:08 kwiesmueller

/gcbrun

dashpole avatar Aug 09 '22 19:08 dashpole