celestia-node icon indicating copy to clipboard operation
celestia-node copied to clipboard

refactor(nodebuilder/pruner)!: Remove --experimental-pruning

Open renaynay opened this issue 5 months ago • 1 comments
trafficstars

Apparently we already had an --archival flag :)

Removes --experimental-pruning and changes default of EnableService in pruner config to true.

We still have a migration tool there that will detect if a node runner attempts to run a node in archival mode after having ran it already in pruned mode, so we have that additional protection.

Closes https://github.com/celestiaorg/celestia-node/issues/4290


Fresh BN init + start:

2025-06-04T16:36:24.193+0200	INFO	module/pruner	pruner/flags.go:38	PRUNING MODE ENABLED. Node will prune blocks to save space.

Pruned BN start with --archival flag:

Error: node has been run with pruner enabled before, it is not safe to convert to an archivalRun with --experimental-pruning enabled or consider re-initializing the store

BN that did not update its config (which changed default value of pruner.EnableService --> true but also did not pass --archival:

2025-06-04T16:39:23.222+0200	FATAL	module/pruner	pruner/flags.go:43	ARCHIVAL MODE ENABLED BY ACCIDENT!!! Please explicitly pass `--archival` to enable archival mode!

renaynay avatar Jun 04 '25 13:06 renaynay

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 35.73%. Comparing base (2469e7a) to head (5d41990). Report is 537 commits behind head on main.

Files with missing lines Patch % Lines
nodebuilder/pruner/flags.go 0.00% 7 Missing :warning:
nodebuilder/pruner/config.go 0.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4303      +/-   ##
==========================================
- Coverage   44.83%   35.73%   -9.10%     
==========================================
  Files         265      307      +42     
  Lines       14620    24182    +9562     
==========================================
+ Hits         6555     8642    +2087     
- Misses       7313    14592    +7279     
- Partials      752      948     +196     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov-commenter avatar Jun 04 '25 13:06 codecov-commenter