celestia-node icon indicating copy to clipboard operation
celestia-node copied to clipboard

fix(test): extendBlock tests

Open moldis opened this issue 5 months ago • 1 comments
trafficstars

  • closes #4252
  • Added unit-tests for extendBlock function, the tests data grabbed from main-net for app_version 1, 2 and 3.
  • kind:testing

moldis avatar Jun 04 '25 04:06 moldis

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 35.15%. Comparing base (2469e7a) to head (19edb3a). :warning: Report is 595 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4298      +/-   ##
==========================================
- Coverage   44.83%   35.15%   -9.68%     
==========================================
  Files         265      304      +39     
  Lines       14620    24296    +9676     
==========================================
+ Hits         6555     8542    +1987     
- Misses       7313    14797    +7484     
- Partials      752      957     +205     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov-commenter avatar Jun 04 '25 04:06 codecov-commenter

Thank you @moldis for making this PR - it's great and I think it would make the most sense once we do https://github.com/celestiaorg/celestia-app/issues/5063

renaynay avatar Jul 31 '25 14:07 renaynay

@moldis Thanks again for this PR 🙏🏻 any chance you'd be able to rebase it on main and add a few more test cases (v4 and v5 blocks on mainnet) ? Please note, we now use da.ConstructEDS for square construction here, so would need the test to use that.

If not, I'm happy to take over this PR.

renaynay avatar Oct 10 '25 14:10 renaynay

@moldis Thanks again for this PR 🙏🏻 any chance you'd be able to rebase it on main and add a few more test cases (v4 and v5 blocks on mainnet) ? Please note, we now use da.ConstructEDS for square construction here, so would need the test to use that.

If not, I'm happy to take over this PR.

Let me update it

moldis avatar Oct 13 '25 08:10 moldis