celestia-node
celestia-node copied to clipboard
feat(api): allow configurable CORS policy
Fixes #3481 kind:feat
Enforces CORS configuration rules and adds middleware handling.
-
Introduces CORS flags (
--rpc.cors-enabled,--rpc.cors-allowed-origins,--rpc.cors-allowed-methods,--rpc.cors-allowed-headers) -
Requires
--rpc.cors-enabled=trueto use any CORS-related flags -
Using
--rpc.skip-authallows all CORS settings (equivalent to * wildcard) -
Provides default values when partial configuration is given
-
Fully overwrites (does not extend) settings when all configurations are provided, giving users complete control
@walldiss Could you please review this PR? Let me know if anything needs further changes. Many thanks 🙏
@walldiss Thanks for looking into the middleware libraries. I’ve added tests for the middleware function—let me know if you think it needs any improvement or additional tests.
Codecov Report
Attention: Patch coverage is 79.54545% with 27 lines in your changes missing coverage. Please review.
Project coverage is 35.54%. Comparing base (
2469e7a) to head (2585c13). Report is 516 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #4266 +/- ##
==========================================
- Coverage 44.83% 35.54% -9.29%
==========================================
Files 265 323 +58
Lines 14620 25195 +10575
==========================================
+ Hits 6555 8956 +2401
- Misses 7313 15270 +7957
- Partials 752 969 +217
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.