celestia-node icon indicating copy to clipboard operation
celestia-node copied to clipboard

feat(p2p): support autotls using IP shipyard

Open koenmtb1 opened this issue 7 months ago • 2 comments
trafficstars

Adding support for autotls as discussed in #4203

Some work to be done

  • [ ] Add tests
  • [ ] Align on approach
  • [ ] Write docs

koenmtb1 avatar Apr 11 '25 15:04 koenmtb1

Codecov Report

Attention: Patch coverage is 20.58824% with 54 lines in your changes missing coverage. Please review.

Project coverage is 44.67%. Comparing base (2469e7a) to head (3a5b328). Report is 484 commits behind head on main.

Files with missing lines Patch % Lines
nodebuilder/p2p/autotls.go 0.00% 28 Missing :warning:
nodebuilder/p2p/flags.go 0.00% 13 Missing :warning:
nodebuilder/p2p/tls.go 50.00% 8 Missing :warning:
nodebuilder/init.go 25.00% 2 Missing and 1 partial :warning:
nodebuilder/store.go 50.00% 2 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4212      +/-   ##
==========================================
- Coverage   44.83%   44.67%   -0.17%     
==========================================
  Files         265      313      +48     
  Lines       14620    23027    +8407     
==========================================
+ Hits         6555    10287    +3732     
- Misses       7313    11619    +4306     
- Partials      752     1121     +369     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov-commenter avatar Apr 14 '25 10:04 codecov-commenter

Hey @koenmtb1, what's the status of this PR? Do you plan to finish it? We would like to have it, and are facing TLS misconfiguration issues (#4319 ) that your PR could fix once and for all

Wondertan avatar Jun 10 '25 08:06 Wondertan