celestia-node icon indicating copy to clipboard operation
celestia-node copied to clipboard

feat!: unify the blob.Proof and the CommitmentProof

Open rach-id opened this issue 1 year ago • 1 comments

Closes https://github.com/celestiaorg/celestia-node/issues/3516 and https://github.com/celestiaorg/celestia-node/issues/3582

Note: added couple notes for reviewers concerning the error handling

rach-id avatar Oct 07 '24 11:10 rach-id

Codecov Report

Attention: Patch coverage is 69.74790% with 36 lines in your changes missing coverage. Please review.

Please upload report for BASE (feature_branch_blob_proof@52bb142). Learn more about missing BASE report.

Files with missing lines Patch % Lines
blob/blob.go 75.60% 15 Missing and 5 partials :warning:
nodebuilder/share/share.go 0.00% 12 Missing :warning:
blob/service.go 91.30% 1 Missing and 1 partial :warning:
nodebuilder/share/mocks/api.go 0.00% 2 Missing :warning:
Additional details and impacted files
@@                     Coverage Diff                      @@
##             feature_branch_blob_proof    #3821   +/-   ##
============================================================
  Coverage                             ?   45.48%           
============================================================
  Files                                ?      313           
  Lines                                ?    21754           
  Branches                             ?        0           
============================================================
  Hits                                 ?     9894           
  Misses                               ?    10844           
  Partials                             ?     1016           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Oct 07 '24 11:10 codecov-commenter

Thanks for the reviews :pray:

Can you merge please? And after ifs merged, you will take care of opening a PR from the feature branch to main?

rach-id avatar Dec 06 '24 12:12 rach-id