celestia-node icon indicating copy to clipboard operation
celestia-node copied to clipboard

chore: a simple e2e test with knuu

Open mojtaba-esk opened this issue 1 year ago • 4 comments

This PR proposes to have a simple e2e test for celestia-node with knuu. The main purpose of this PR is to show how to use knuu for e2e tests.

mojtaba-esk avatar Oct 02 '24 14:10 mojtaba-esk

currently the following error is thrown and the progress is blocked due to that:

$ make test-e2e 
--> Running end to end tests
go run ./test/e2e 
2024/10/02 18:16:03 proto: duplicate proto type registered: celestia.core.v1.da.DataAvailabilityHeader
2024/10/02 18:16:04 proto: duplicate proto type registered: celestia.core.v1.proof.ShareProof
2024/10/02 18:16:04 proto: duplicate proto type registered: celestia.core.v1.proof.RowProof
2024/10/02 18:16:04 proto: duplicate proto type registered: celestia.core.v1.proof.NMTProof
2024/10/02 18:16:04 proto: duplicate proto type registered: celestia.core.v1.proof.Proof
2024/10/02 18:16:04 proto: duplicate proto type registered: celestia.core.v1.tx.TxStatusRequest
2024/10/02 18:16:04 proto: duplicate proto type registered: celestia.core.v1.tx.TxStatusResponse
panic: error with code 1 is already registered: "invalid signal version because signal version can not be less than the current version"

goroutine 1 [running]:
cosmossdk.io/errors.RegisterWithGRPCCode({0x314d082, 0x6}, 0x1, 0x2, {0x325ebed, 0x56})
	/home/moji/go/pkg/mod/cosmossdk.io/[email protected]/errors.go:43 +0x265
cosmossdk.io/errors.Register(...)
	/home/moji/go/pkg/mod/cosmossdk.io/[email protected]/errors.go:35
github.com/celestiaorg/celestia-app/v3/x/signal/types.init()
	/home/moji/go/pkg/mod/github.com/celestiaorg/celestia-app/[email protected]/x/signal/types/errors.go:8 +0x45
exit status 2
make: *** [Makefile:158: test-e2e] Error 1

update: This one is fixed and no longer an issue

mojtaba-esk avatar Oct 02 '24 14:10 mojtaba-esk

Codecov Report

Attention: Patch coverage is 0% with 852 lines in your changes missing coverage. Please review.

Project coverage is 43.74%. Comparing base (2469e7a) to head (60cae30). Report is 385 commits behind head on main.

Files with missing lines Patch % Lines
test/e2e/simple.go 0.00% 151 Missing :warning:
test/e2e/testnet/node.go 0.00% 145 Missing :warning:
test/e2e/testnet/instance_options.go 0.00% 138 Missing :warning:
test/e2e/testnet/status.go 0.00% 110 Missing :warning:
test/e2e/prometheus/prometheus.go 0.00% 106 Missing :warning:
test/e2e/testnet/testnet.go 0.00% 84 Missing :warning:
test/e2e/testnet/helper.go 0.00% 55 Missing :warning:
test/e2e/main.go 0.00% 39 Missing :warning:
test/e2e/testnet/executor.go 0.00% 24 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3795      +/-   ##
==========================================
- Coverage   44.83%   43.74%   -1.10%     
==========================================
  Files         265      317      +52     
  Lines       14620    22710    +8090     
==========================================
+ Hits         6555     9934    +3379     
- Misses       7313    11708    +4395     
- Partials      752     1068     +316     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Oct 02 '24 14:10 codecov-commenter

Update: by pointing to the feature_branch_app_v3 the issue of app version conflict is resolved.

mojtaba-esk avatar Oct 08 '24 08:10 mojtaba-esk

Update: since we need to activate Minio and probably some other options for the node tests, we need to wait for this PR in the celestia-app repo to be reviewed.

mojtaba-esk avatar Oct 08 '24 15:10 mojtaba-esk

Closing as superseded by #3983

renaynay avatar Jan 29 '25 16:01 renaynay