cedvdb

Results 222 comments of cedvdb
trafficstars

Yes I did but only with audio/weba files, which did work.

1. In regards to serialization, the implementation above would fail in the presence of a private field. `json[field.name]` won't work for this simple class if the json is `{bar: 3}`....

I like the "Declaring" syntax, it is more readable than the "initializing" syntax because the intent is mandatory / explicit with "var" or "final" and consistent, and the novar is...

@mmcdon20 I think your initializing block should be ```dart class Rectangle { // intitializing const this({required final int this.height, required final int this.width}); // declaring const this({required final int height,...

I really like the idea of decreasing the redundancy when declaring multiple constructors. I prefer a [`this.*` syntax](https://github.com/dart-lang/language/issues/2364#issuecomment-2633090628) that I find more expressive than `...`

> It allows shorter simple data classes, like final class const Point(int this.x, int this.y);. That's nice. A record would be even shorter. Personally I don't see the added value...

@tolo I'm not sure I understand the point of this PR. `router.go('/branchA');` already works. Why would a number in the URL be desirable ( when you consider the web platform...

What's the status here ? It seems like you said that you have a test locally that's failing but it's unrelated to the changes here ?

@chunhtai Can autosubmit be added ? as conflicts were already resolved 2 weeks ago