dokku-deployment-keys icon indicating copy to clipboard operation
dokku-deployment-keys copied to clipboard

Plugin broken in dokku 35.16 when building with herokuish

Open kevinob11 opened this issue 8 months ago • 4 comments

When I try to rebuild an app I get the following error

-----> Cleaning up... -----> Building praece-vault from herokuish -----> Adding BUILD_ENV to build environment... BUILD_ENV added successfully -----> Adding host-keys to build environment ... Adding shared keys docker: 'docker wait' requires at least 1 argument

Usage: docker wait CONTAINER [CONTAINER...]

See 'docker wait --help' for more information /var/lib/dokku/plugins/enabled/hostkeys-plugin/pre-build: line 41: test: -eq: unary operator expected ! Removing invalid image tag dokku/praece-vault:latest ! App build failed ! docker: 'docker wait' requires at least 1 argument

Usage: docker wait CONTAINER [CONTAINER...]

See 'docker wait --help' for more information /var/lib/dokku/plugins/enabled/hostkeys-plugin/pre-build: line 41: test: -eq: unary operator expected ! Removing invalid image tag dokku/praece-vault:latest ! App build failed

kevinob11 avatar Mar 09 '25 04:03 kevinob11

Can you show the output of dokku report $APP as well as turn on debug logging, trigger a rebuild, and paste the output here?

josegonzalez avatar Mar 09 '25 10:03 josegonzalez

Actually, would it be better to just use a buildpack for this? For instance, this one handles both a deployment key as well as host keys: https://elements.heroku.com/buildpacks/moneymeets/ssh-private-key-buildpack

josegonzalez avatar Mar 09 '25 10:03 josegonzalez

Ah, I was wondering about other options given these don't seem to be heavily used. I'll do this either with a dockerfile deploy, which we're mostly moving to, or this buildpack. Thank you!

kevinob11 avatar Mar 10 '25 03:03 kevinob11

I think maybe the buildpack is easiest thing here if you're already deploying via herokuish buildpacks.

josegonzalez avatar Mar 10 '25 17:03 josegonzalez