php-openapi icon indicating copy to clipboard operation
php-openapi copied to clipboard

Published 20 hours ago • verified publisher icon cebe

[openapi v3.1] PHP 8.2 deprecations

Open WyriHaximus opened this issue 2 years ago • 10 comments

WyriHaximus avatar Jan 13 '23 15:01 WyriHaximus

@cebe LGTM :)

rogervila avatar Jan 27 '23 10:01 rogervila

Suggestion: We might want to add Php 8.2 to .github/workflows/php.yml to reduce the risk of regression going forward.

pieterocp avatar Feb 02 '23 16:02 pieterocp

@pieterocp Whoops good point, I sometimes forget not everyone automated dealing with that out of their mind 😅 . Will either update this PR or file a PR to introduce that. (But probably both.)

WyriHaximus avatar Feb 02 '23 20:02 WyriHaximus

@WyriHaximus As cebe seems don't manage this repository from long time ago, and I have created and published a fork of this library. So if you want to use this changes you can send the PR to https://github.com/DEVizzent/cebe-php-openapi

DEVizzent avatar Feb 19 '23 07:02 DEVizzent

@DEVizzent Sure, did you also pull in the other PR's in I have open here? Looks like you also kept the namespaces the same so it's usable as, hopefully, a temporary drop in until @cebe has time for this package again :+1:

WyriHaximus avatar Feb 20 '23 07:02 WyriHaximus

@WyriHaximus No sorry I didn't pull them. If you want to do it it will be great, if not I will do it next weekend.

DEVizzent avatar Feb 20 '23 11:02 DEVizzent

@DEVizzent Sure will do :+1:

WyriHaximus avatar Feb 20 '23 20:02 WyriHaximus

@DEVizzent Any plans with the clone you made? Got the PR's in there as you requested but don't seen any activity on them yet

WyriHaximus avatar Mar 21 '23 11:03 WyriHaximus

@WyriHaximus sorry, I didn't get any notification. I will take a look tomorrow. I use to spend time on Open Software all Thursday.

DEVizzent avatar Mar 22 '23 18:03 DEVizzent

@DEVizzent Doh yeah then it all makes sense :joy: .

WyriHaximus avatar Mar 23 '23 07:03 WyriHaximus

pipeline on master is currently running against php 8.1, 8.2 and 8.3, is this still relevant?

cebe avatar Feb 07 '25 11:02 cebe

I think this was implemented in (Nov 14, 2024) https://github.com/cebe/php-openapi/commit/2ebe61852ed729d1bb632b8591f516c6bb7416f5

Sweetchuck avatar Feb 07 '25 15:02 Sweetchuck

pipeline on master is currently running against php 8.1, 8.2 and 8.3, is this still relevant?

No clue, will have a look some time this weekend.

I think this was implemented in (Nov 14, 2024) 2ebe618

Huh? That change is about yaml, the code in this PR is PHP

WyriHaximus avatar Feb 07 '25 21:02 WyriHaximus

Yes, that is true, but the PHP code changed earlier. I haven't check if all the modifications from this PR are already in the master or not. I just check some of them.

https://github.com/cebe/php-openapi/blob/master/src/spec/Paths.php#L186

Sweetchuck avatar Feb 08 '25 11:02 Sweetchuck