faktory_worker_python icon indicating copy to clipboard operation
faktory_worker_python copied to clipboard

Batch Support

Open sk3tch opened this issue 4 years ago • 3 comments
trafficstars

I reached out to Mike Perham about batch support in Python and he asked me to open an issue here.

sk3tch avatar Jul 27 '21 19:07 sk3tch

Thanks!

The Ruby gem provides the best and easiest reference for batch clients in other languages. The Faktory::Batch object represents a Batch:

https://github.com/contribsys/faktory_worker_ruby/blob/master/lib/faktory/batch.rb

and the BATCH protocol operations are implemented in Faktory::Client:

https://github.com/contribsys/faktory_worker_ruby/blob/c58f758d4c6d79bd57be71354c2a55a5149dd079/lib/faktory/client.rb#L76-L126

Finally, the batch client middleware connects each new job with its associated Batch when it is sent to Faktory:

https://github.com/contribsys/faktory_worker_ruby/blob/master/lib/faktory/middleware/batch.rb

If this is something you are interested in supporting in Python, let me know.

mperham avatar Jul 27 '21 20:07 mperham

Hi @sk3tch,

This repository doesn't seem to be maintained anymore. I've reimplemented a Faktory Python client here, I invite you to check it out. I will try to add batch support in the next days.

ghilesmeddour avatar Sep 11 '21 19:09 ghilesmeddour

I do maintain this repo, but don't have as much time to work on it as I would like.

I'll fix any bugs that come up (there are not many now, this project is pretty stable I think) but I won't personally implement new features.

If someone wants to build this feature and open a PR, I would gladly merge it.

cdrx avatar Apr 30 '22 09:04 cdrx