openMVS icon indicating copy to clipboard operation
openMVS copied to clipboard

Image coordinate system

Open SubChange opened this issue 2 years ago • 3 comments

In colmap Docs, It says that:

Note that by convention the upper left corner of an image has coordinate (0, 0) and the center of the upper left most pixel has coordinate (0.5, 0.5). If you must import features for large image collections, it is much more efficient to directly access the database with your favorite scripting language (see Database Format).

However, In OpenMVS, it says:

The projection in image coordinates uses the convention that the center of a pixel is defined at integer coordinates, i.e. the center is at (0, 0) and the top left corner is at (-0.5, -0.5). All matrices are expected in row-major format.

In apps/InterfaceCOLMAP, I don't see the conversion about the 0.5 pixel shift, Is this cause any errors?

SubChange avatar Oct 14 '23 15:10 SubChange

good point, I did not notice that the pixel center convention is different, thank you feel free to add a fix if you can, if not I'll try to find some time next weekend

cdcseacave avatar Oct 16 '23 07:10 cdcseacave

good point, I did not notice that the pixel center convention is different, thank you feel free to add a fix if you can, if not I'll try to find some time next weekend

Thank you very much, I ‘d like to try but I am not good at c++. So, I'd greatly appriciate it if you can correct that.

SubChange avatar Oct 17 '23 01:10 SubChange

should be solved here, pls give it a try

cdcseacave avatar Oct 17 '23 16:10 cdcseacave