🚨 Fix new warnings revealed by clang-tidy 18

[burgholzer]

Description

This PR aims to fix all the new warnings that were introduced in clang-tidy versions 18, which have been enabled with the switch to the [email protected].

The first commit, which will later be reverted, just triggers a full clang-tidy run on the whole codebase.

Checklist:

• [ ] The pull request only contains commits that are related to it.
• [ ] I have added appropriate tests and documentation.
• [ ] I have made sure that all CI jobs on GitHub pass.
• [ ] The pull request introduces no new warnings and follows the project's style guidelines.

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 97.34789% with 17 lines in your changes missing coverage. Please review.

Project coverage is 90.5%. Comparing base (b717265) to head (bede18e). Report is 67 commits behind head on main.

Files with missing lines	Patch %	Lines
src/DataLogger.cpp	87.5%	4 Missing :warning:
src/configuration/Configuration.cpp	85.7%	3 Missing :warning:
src/na/NAMapper.cpp	95.7%	3 Missing :warning:
include/Architecture.hpp	71.4%	2 Missing :warning:
include/hybridmap/HybridNeutralAtomMapper.hpp	0.0%	2 Missing :warning:
include/Mapper.hpp	83.3%	1 Missing :warning:
include/configuration/CommanderGrouping.hpp	50.0%	1 Missing :warning:
include/configuration/Encoding.hpp	50.0%	1 Missing :warning:

Additional details and impacted files

@@           Coverage Diff           @@
##            main    #462     +/-   ##
=======================================
- Coverage   90.5%   90.5%   -0.1%     
=======================================
  Files         86      86             
  Lines      10023   10024      +1     
  Branches    1710    1712      +2     
=======================================
- Hits        9073    9072      -1     
- Misses       950     952      +2     

Flag	Coverage Δ
cpp	90.2% <97.3%> (-0.1%)	:arrow_down:
python	95.9% <ø> (ø)

Files with missing lines	Coverage Δ
include/DataLogger.hpp	100.0% <ø> (ø)
include/MappingResults.hpp	83.3% <100.0%> (ø)
include/cliffordsynthesis/CliffordSynthesizer.hpp	88.1% <ø> (ø)
include/cliffordsynthesis/Configuration.hpp	100.0% <ø> (ø)
include/cliffordsynthesis/Results.hpp	100.0% <100.0%> (ø)
include/cliffordsynthesis/Tableau.hpp	86.6% <ø> (ø)
include/cliffordsynthesis/TargetMetric.hpp	47.0% <ø> (ø)
include/cliffordsynthesis/encoding/GateEncoder.hpp	88.8% <ø> (ø)
...de/cliffordsynthesis/encoding/ObjectiveEncoder.hpp	100.0% <ø> (ø)
include/cliffordsynthesis/encoding/SATEncoder.hpp	100.0% <ø> (ø)
... and 67 more