pycba icon indicating copy to clipboard operation
pycba copied to clipboard

Sum of envelopes + example

Open RoccoRaimo opened this issue 1 year ago • 3 comments

Hi @ccaprani! I've implemented the new method in class Envelopes to sum multiple envelopes, as described in #92, and included the example n.5 to show a possible usage scenario.

Let me know if everything is straight and clear! Thanks.

RoccoRaimo avatar May 16 '24 12:05 RoccoRaimo

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.38%. Comparing base (9322c65) to head (8432283). Report is 22 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #93      +/-   ##
==========================================
+ Coverage   79.97%   84.38%   +4.41%     
==========================================
  Files          13       14       +1     
  Lines        1368     1684     +316     
==========================================
+ Hits         1094     1421     +327     
+ Misses        274      263      -11     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov-commenter avatar May 16 '24 12:05 codecov-commenter

At the end of the example in the notebook I inserted a numerical control of the results between a "manual" sum of the results and the "automatic" one that comes with the use of the new function. Don't know if it makes sense to create a separate test. Let me know once you'll look up at the notebook :)

RoccoRaimo avatar May 16 '24 15:05 RoccoRaimo

Hi Colin! Have you had a look at the notebook with the example on it?

RoccoRaimo avatar Jul 25 '24 13:07 RoccoRaimo

Hi @ccaprani, I've added the file test_tesults.py that contains a test for sum of compatible envelopes and another one to verify if two incompatible envelopes are used (ex. 2 envelopes of results with different spans number). Let me know if it is enough to merge the pull request and update the package. Thanks!

RoccoRaimo avatar Apr 10 '25 10:04 RoccoRaimo

Hi @RoccoRaimo - thank you so much for this. I made a few small tweaks on my local, but can't add to this PR. Can click "Allow edits from maintainers" please? You should see it on the PR from your view.

ccaprani avatar Apr 12 '25 04:04 ccaprani

Hi @ccaprani, it was already checked. I unchecked and re-checked it, try now and let me know. Thanks.

RoccoRaimo avatar Apr 12 '25 14:04 RoccoRaimo