Clemens Brunner

Results 676 comments of Clemens Brunner

Hi @lxkain! Nice project! It seems like TimeView focusses on audio-like signals (or at least the interface and many functions are tailored towards such time series). In contrast, MNELAB implements...

I wouldn't say the same goals, but related ones. Otherwise, agreed.

I watched the video - again, great work! MNELAB aims to provide a graphical wrapper to MNE-Python. More specifically, the two major use cases of MNELAB are: 1. Supplement MNE-Python...

I like the idea. This would require careful thinking though. For example, it could be necessary to group multiple Python statements into one history entry. Furthermore, maybe this kind of...

> If nodes with only one child weren't indented the trees would grow downwards. Good idea. > Also, if it were possible to define blocks/containers of several steps the boilerplate...

I'm not sure this is the same issue, but at least for MNE-Python I get very strange docstrings when hovering over a method (in the example, I'm using `mne.time_frequency.tfr_multitaper` [source](https://github.com/mne-tools/mne-python/blob/main/mne/time_frequency/tfr.py#L813))....

Are we sure it's not our fault? The `verbose` function doesn't use the `functools.wraps` decorator, although it seems like we're using `decorator.FunctionMaker` instead, which should do the same thing. I...

As a workaround for now, rendering as `github_document` might be an option: https://rmarkdown.rstudio.com/github_document_format.html

+1 for extending the `padmode` parameter to act like `mode` in [`np.correlate`](https://numpy.org/doc/stable/reference/generated/numpy.convolve.html#numpy.convolve). Specifically, I'd find `mode="same"` very useful (so `padmode=:same`), which gives the middle samples.

So we meet in Julia land 😄 ! I'm not sure I have the time to tackle all enhancements mentioned in the top post, but I could at least try...