kobalt-intellij-plugin icon indicating copy to clipboard operation
kobalt-intellij-plugin copied to clipboard

Published 20 hours ago • verified publisher icon cbeust

Retrofit library stop working inside plugin

Open dmitry-zhuravlev opened this issue 8 years ago • 2 comments
trafficstars

Recently I noticed that retrofit library stop working inside plugin. Currently we use this library to invoke some commands like ping, quit on Kobalt server. We have the same situation like described here: https://github.com/square/retrofit/issues/2102

The reason is that Retrofit try to determine the running platform by executing Class.forName("android.os.Build") So it works previously but stop working for now. The explanation can be found in comments here: https://github.com/square/retrofit/pull/2103

android.os.Builder class was not on the classpath in the IDEA 2016.2 version of the Android Support plugin but has appeared on the classpath in the 2016.3 version.

So it seems that current bundled version of Retrofit library not suited anymore for us. So we can:

  • Switch to another library
  • Try to build this library from source including fix https://github.com/square/retrofit/pull/2103 and test if it works.

What do you think @cbeust ?

dmitry-zhuravlev avatar Feb 14 '17 11:02 dmitry-zhuravlev

Provided some temporary solution with Retrofit library which is builded manually. Should be updated to the actual release version of library as soon as https://github.com/square/retrofit/pull/2103 will be merged.

dmitry-zhuravlev avatar Feb 14 '17 12:02 dmitry-zhuravlev

Not crazy about having our own version of public libraries but as long as it's temporary until Retrofit merges their fix, not a big deal. Thanks for catching this!

-- Cédric

On Tue, Feb 14, 2017 at 4:50 AM, Dmitry Zhuravlev [email protected] wrote:

Provided some temporary solution with Retrofit library which is builded manually. Should be updated to the actual release version of library as soon as square/retrofit#2103 https://github.com/square/retrofit/pull/2103 will be merged.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/cbeust/kobalt-intellij-plugin/issues/61#issuecomment-279698948, or mute the thread https://github.com/notifications/unsubscribe-auth/AAFoohS13eg1S33n2m-gj3fRzuHR932tks5rcaMFgaJpZM4MAYg7 .

cbeust avatar Feb 14 '17 18:02 cbeust