Cedric Beust

Results 188 comments of Cedric Beust
trafficstars

> Tests need to be fixed That's another cause for concern, and why I think this change might break existing users.

I share @juherr's concern. I understand where this change is coming from and I think an argument can be made that "after" listeners should be run after their `After` method,...

Yes. that's a reasonable request.

Mmmh... not sure I see the point. One of these switches will basically set the boolean to the value it already has by default, right? JCommander already lets you set...

This is almost exactly why I pretty much stopped accepting pull requests to change the `usage()` format: these are guaranteed to make as many people happy as unhappy. The bottom...

Thanks for the detailed answer, @lazee. I think the take away is that I'd rather focus my energy on improving `ParameterDescription` and surrounding API's so that everyone can write their...

Please see my comment at https://github.com/cbeust/jcommander/issues/217#issuecomment-76851212 I don't think it's worth it to make `usage()` customizable for the reason above.

@martinjmares Sure, happy to accept internationalization pull requests (note that JCommander [already lets you internationalize your parameters](http://jcommander.org/#Internationalization) ). And yes, that PR would need to be rebased to be useful...

Sounds like `columnsSize` should be configurable with the builder, without requiring to override the `JCommander` class. Would you like to send a pull request?

I'd be open to that. The current implementation (which is pretty ugly, I agree) could simply be hidden behind the `DefaultUsage` instance. `ParameterDescription` is the standard way to obtain parameter...