terraform-aws-gitlab-runner icon indicating copy to clipboard operation
terraform-aws-gitlab-runner copied to clipboard

chore: fix TfSec issues

Open kayman-mk opened this issue 3 years ago • 0 comments
trafficstars

Description

This PR fixes all mentioned TfSec issues reported by the pipeline.

  • encrypt all resources either with the provided/generated customer managed key or the default AWS key
  • use a ARN in policies instead of *
  • remove unnecessary policies
  • allow activation of X-Ray tracing via variable

Migrations required

No

Verification

  • [ ] deploy/destroy runner-default
  • [ ] termination lambda can write logs
  • [ ] runners can still access the cache
  • [ ] access logs are written if the feature is enabled
  • [ ] update Hapag-Lloyd runners to this version and ensure everything is running

kayman-mk avatar Oct 12 '22 18:10 kayman-mk