terraform-aws-gitlab-runner icon indicating copy to clipboard operation
terraform-aws-gitlab-runner copied to clipboard

Add support for shell executor

Open ivankovnatsky opened this issue 3 years ago • 5 comments
trafficstars

Would be great to be able to configure shell executor: https://docs.gitlab.com/runner/executors/shell.html

ivankovnatsky avatar Dec 16 '21 08:12 ivankovnatsky

@ivankovnatsky Could you provide more details please? At the moment I do not see any advantage of supporting another runner type. But there might be use cases I do not know. What is the advantage of a shell runner?

kayman-mk avatar Dec 28 '21 15:12 kayman-mk

I usually don't build container images using docker-in-docker, so I thought it would be great to have a shell runner with docker.

But yeah, if community does not feel it's necessary, that might not make sense to do it.

ivankovnatsky avatar Dec 29 '21 08:12 ivankovnatsky

Could be a nice extension, @ivankovnatsky Any chance to get a PR from you on how to change the current template to support other executors?

kayman-mk avatar Jan 05 '22 11:01 kayman-mk

I quickly checked the linked documentation. In the current setup we have one Gitlab Runner + many executors (docker machines). The shell executor is running on the runner directly. So there are no executors and thus this might create problems with higher workloads (no scaling). This can be fixed by deploying the module several times of course.

kayman-mk avatar Jan 05 '22 12:01 kayman-mk

Could be a nice extension, @ivankovnatsky Any chance to get a PR from you on how to change the current template to support other executors?

sure, though can quite promise the timing and not the highest priority at my current employer.

ivankovnatsky avatar Jan 05 '22 18:01 ivankovnatsky

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 15 days.

github-actions[bot] avatar Mar 18 '23 02:03 github-actions[bot]

This issue was closed because it has been stalled for 15 days with no activity.

github-actions[bot] avatar Apr 03 '23 02:04 github-actions[bot]

@ivankovnatsky I have a similar need. How did you solve this issue?

lmilbaum avatar Oct 26 '23 06:10 lmilbaum

@lmilbaum Could you please elaborate on your use case? Can it be solved with the docker or docker+machine executor?

kayman-mk avatar Oct 26 '23 09:10 kayman-mk