terraform-aws-gitlab-runner
terraform-aws-gitlab-runner copied to clipboard
cattle-ops
fix: avoid creating some resources if runners_executor is not docker+machine
Description
No need to create the some resources that are directly relevant to docker machine since variable runners_executor does not have value docker+machine.
Migrations required
NO - If yes please describe the migration.
Verification
Please mention the examples you have verified.
Documentation
We use pre-commit to update the Terraform inputs and outputs in the documentation via terraform-docs. Ensure you have installed those components.
Hi @npalm , could you please review this MR? I'd like to hear your feedback.
Hi @npalm , could you please review this MR? I'd like to hear your feedback.
Thx for the reminder, will check over the weekend. Was on holiday 🌴 last month
@npalm It was my bad. I pushed a new commit that contains fix for that error and some terraform fmt changes as well. terraform validate should no longer throw an error relevant to these changes.
I think it's failed because of formatting it with the newer version of Terraform. I re-ran the terraform fmt command with Terraform 0.12 and pushed it. Verify module step should pass now.
I have updated several versions, including terraform. The modules can now be developed with the latest Terraform version. For usages it still supports older versions. Please can you rebase to the latest commit on develop? git rebase -i develop
@halilkaya did you have time to have a look on the remarks made in the review?