terraform-aws-gitlab-runner
terraform-aws-gitlab-runner copied to clipboard
feat: shell is also a supported executor
Description
A few sentences describing the overall goals of the pull request's commits.
Migrations required
YES | NO - If yes please describe the migration.
Verification
Please mention the examples you have verified.
Hey @lmilbaum! 👋
Thank you for your contribution to the project. Please refer to the contribution rules for a quick overview of the process.
Make sure that this PR clearly explains:
- the problem being solved
- the best way a reviewer and you can test your changes
With submitting this PR you confirm that you hold the rights of the code added and agree that it will published under this LICENSE.
The following ChatOps commands are supported:
/help: notifies a maintainer to help you out
Simply add a comment with the command in the first line. If you need to pass more information, separate it with a blank line from the command.
This message was generated automatically. You are welcome to improve it.
I know it's not ready for review. But I saw the changes in the variables.tf which are not backwards compatible. We can only do that with the v8 release end of 2024.
I know it's not ready for review. But I saw the changes in the variables.tf which are not backwards compatible. We can only do that with the v8 release end of 2024.
IC. Thank you for your feedback. I'll do some changes.
@lmilbaum Are you still working on this feature?
@lmilbaum Are you still working on this feature?
Sorry. Don't have the cycles for it in the coming weeks. If you or any one else wants to chime in.
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 15 days.
Closing due to no actions for more than a year.