terraform-aws-gitlab-runner icon indicating copy to clipboard operation
terraform-aws-gitlab-runner copied to clipboard

feat: shell is also a supported executor

Open lmilbaum opened this issue 2 years ago • 6 comments
trafficstars

Description

A few sentences describing the overall goals of the pull request's commits.

Migrations required

YES | NO - If yes please describe the migration.

Verification

Please mention the examples you have verified.

lmilbaum avatar Nov 11 '23 19:11 lmilbaum

Hey @lmilbaum! 👋

Thank you for your contribution to the project. Please refer to the contribution rules for a quick overview of the process.

Make sure that this PR clearly explains:

  • the problem being solved
  • the best way a reviewer and you can test your changes

With submitting this PR you confirm that you hold the rights of the code added and agree that it will published under this LICENSE.

The following ChatOps commands are supported:

  • /help: notifies a maintainer to help you out

Simply add a comment with the command in the first line. If you need to pass more information, separate it with a blank line from the command.

This message was generated automatically. You are welcome to improve it.

github-actions[bot] avatar Nov 11 '23 19:11 github-actions[bot]

I know it's not ready for review. But I saw the changes in the variables.tf which are not backwards compatible. We can only do that with the v8 release end of 2024.

kayman-mk avatar Nov 11 '23 20:11 kayman-mk

I know it's not ready for review. But I saw the changes in the variables.tf which are not backwards compatible. We can only do that with the v8 release end of 2024.

IC. Thank you for your feedback. I'll do some changes.

lmilbaum avatar Nov 12 '23 11:11 lmilbaum

@lmilbaum Are you still working on this feature?

kayman-mk avatar Nov 30 '23 09:11 kayman-mk

@lmilbaum Are you still working on this feature?

Sorry. Don't have the cycles for it in the coming weeks. If you or any one else wants to chime in.

lmilbaum avatar Dec 01 '23 05:12 lmilbaum

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 15 days.

github-actions[bot] avatar Jan 31 '24 02:01 github-actions[bot]

Closing due to no actions for more than a year.

kayman-mk avatar Aug 14 '25 08:08 kayman-mk