ws2812-esp32-rmt-driver icon indicating copy to clipboard operation
ws2812-esp32-rmt-driver copied to clipboard

Published 20 hours ago • verified publisher icon cat-in-136

Update for newer HAL

Open DavidVentura opened this issue 1 year ago • 4 comments

This change depends on https://github.com/esp-rs/esp-idf-hal/pull/386 getting merged and a new version getting tagged. Alternatively, we can store t0h, t0l, t1h, t1l and create a new Symbol for each bit in the iterator; I'm not sure if Copy will be faster than creating the Symbol

Closes #42

DavidVentura avatar Mar 03 '24 21:03 DavidVentura

Updated .github/workflows/rust.yml is also needed to upgrade rust version on github workflow. Your code could not are compiled even on my local using the latest rust version.

cat-in-136 avatar Mar 10 '24 05:03 cat-in-136

I prefer your approach since less complexity in encode_iter() function than #41. But I wonder that it is impossible to refer just Symbol variable in encode_iter(). Symbol does not seem to implement neither Copy or Clone.

cat-in-136 avatar Mar 10 '24 05:03 cat-in-136

I linked a PR where Symbol got made Copy, but it's not released yet. This is why I used a not-yet-existent version of esp-idf-hal

DavidVentura avatar Mar 10 '24 08:03 DavidVentura

Also solves this issue: #48

mn-xd avatar May 09 '24 17:05 mn-xd