nutshell icon indicating copy to clipboard operation
nutshell copied to clipboard

Improve documentation about how to run tests

Open xphade opened this issue 2 years ago • 3 comments

Right now there is some important information missing about how to run and pass the tests. Some examples include:

  • TOR=FALSE is documented, but you also have to remove SOCKS_HOST/PORT from the env file
  • tests/test_cli.py::test_nostr_send fails for me if a nostr key is set (not sure if bug or expected)
  • Do any directories have to be cleaned? At least for me the tests are quite flaky, and I'm not sure if that's due to any data that is still in ~/.cashu or ./data

Some of this can be improved by documentation. But maybe we can also set up the tests slightly differently, so that they are not that dependent on the .env file.

xphade avatar May 13 '23 12:05 xphade

Do any directories have to be cleaned?

I think ~/.cashu/test_wallet does, or at least sometimes :laughing:

AngusP avatar May 17 '23 23:05 AngusP

Thank you very much for bringing up this point. I also think that LIGHTNING=False needs to be set (on my machine here). I would much rather like to use FakeWallet and get rid of Lightning=False in the entire code base altogether, tbh.

callebtc avatar May 23 '23 11:05 callebtc

Thank you very much for bringing up this point. I also think that LIGHTNING=False needs to be set (on my machine here). I would much rather like to use FakeWallet and get rid of Lightning=False in the entire code base altogether, tbh.

Agreed, that would be awesome as well.

When we're working on the tests anyway, we can also incorporate this comment that didn't make it into the merged change.

xphade avatar May 23 '23 16:05 xphade