nutshell
nutshell copied to clipboard
Improve documentation about how to run tests
Right now there is some important information missing about how to run and pass the tests. Some examples include:
TOR=FALSEis documented, but you also have to removeSOCKS_HOST/PORTfrom the env filetests/test_cli.py::test_nostr_sendfails for me if a nostr key is set (not sure if bug or expected)- Do any directories have to be cleaned? At least for me the tests are quite flaky, and I'm not sure if that's due to any data that is still in
~/.cashuor./data
Some of this can be improved by documentation. But maybe we can also set up the tests slightly differently, so that they are not that dependent on the .env file.
Do any directories have to be cleaned?
I think ~/.cashu/test_wallet does, or at least sometimes :laughing:
Thank you very much for bringing up this point. I also think that LIGHTNING=False needs to be set (on my machine here). I would much rather like to use FakeWallet and get rid of Lightning=False in the entire code base altogether, tbh.
Thank you very much for bringing up this point. I also think that
LIGHTNING=Falseneeds to be set (on my machine here). I would much rather like to useFakeWalletand get rid ofLightning=Falsein the entire code base altogether, tbh.
Agreed, that would be awesome as well.
When we're working on the tests anyway, we can also incorporate this comment that didn't make it into the merged change.