redis-adapter icon indicating copy to clipboard operation
redis-adapter copied to clipboard

Published 20 hours ago • verified publisher icon casbin

redis adapter panics when redis is down, maybe handle it with an error?

Open sujatapatnaik52 opened this issue 3 years ago • 6 comments

sujatapatnaik52 avatar Sep 14 '22 14:09 sujatapatnaik52

@tangyang9464 @JalinWang @imp2002

casbin-bot avatar Sep 14 '22 14:09 casbin-bot

@sujatapatnaik52 can you paste the panic code stack here?

@JalinWang

/cc @tangyang9464

hsluoyz avatar Sep 15 '22 01:09 hsluoyz 

root@dev:/home/sujata/learning/casbin_fixes# go run main.go 
panic: dial tcp 127.0.0.1:6379: connect: connection refused

goroutine 1 [running]:
github.com/casbin/redis-adapter/v2.(*Adapter).open(0xc0000b2230)
	/root/go/pkg/mod/github.com/casbin/redis-adapter/[email protected]/adapter.go:127 +0x12a
github.com/casbin/redis-adapter/v2.newAdapter({0x6bfe00, 0x3}, {0x6c2425, 0xe}, {0x6c1ded, 0xc}, {0x0, 0x0})
	/root/go/pkg/mod/github.com/casbin/redis-adapter/[email protected]/adapter.go:60 +0x105
github.com/casbin/redis-adapter/v2.NewAdapter(...)
	/root/go/pkg/mod/github.com/casbin/redis-adapter/[email protected]/adapter.go:70
main.main()
	/home/sujata/learning/casbin_fixes/main.go:195 +0x70
exit status 2

sujatapatnaik52 avatar Sep 15 '22 08:09 sujatapatnaik52

@JalinWang

hsluoyz avatar Sep 16 '22 13:09 hsluoyz

@tangyang9464 Do you think how should we design the behavior? I think panic is reasonable 🤔Or do we need to introduce a retry mechanism?

JalinWang avatar Sep 16 '22 14:09 JalinWang

@JalinWang should return error instead of panic, at the same time, a retry mechanism can be added

tangyang9464 avatar Sep 16 '22 14:09 tangyang9464

@imp2002

hsluoyz avatar Nov 04 '22 14:11 hsluoyz

:tada: This issue has been resolved in version 3.0.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

github-actions[bot] avatar Nov 10 '22 12:11 github-actions[bot]