node-casbin icon indicating copy to clipboard operation
node-casbin copied to clipboard

feat: add support for g() in SyncedEnforcer

Open Sefriol opened this issue 3 years ago • 2 comments

Based on @Zxilly 's work in: https://github.com/casbin/node-casbin/pull/303

Fixed the issue of generateGFuncion being async, therefore not working in syncedEnforcer.

I am not sure if the implementation is clear enough, but I created some tests which should cover the issue pretty well.

Sefriol avatar Aug 08 '22 11:08 Sefriol

@nodece @Zxilly @Shivansh-yadav13 please review

casbin-bot avatar Aug 08 '22 11:08 casbin-bot

@Zxilly @Shivansh-yadav13 plz review

hsluoyz avatar Aug 08 '22 11:08 hsluoyz

Removed one unnecessary import.

Sefriol avatar Aug 11 '22 12:08 Sefriol

@Zxilly @nodece @WenyXu plz review

hsluoyz avatar Aug 11 '22 12:08 hsluoyz