casbin-cpp icon indicating copy to clipboard operation
casbin-cpp copied to clipboard

[CMake] Automated versioning

Open EmperorYP7 opened this issue 3 years ago • 4 comments

Description

The version specified in CMake config and the version released by GitHub Actions is not the same and can be really confusing for the clients. We can automate the versioning to coincide the CMake version with the GH version of casbin-cpp through another GitHub Action which should trigger on push to master branch.

EmperorYP7 avatar Nov 21 '21 14:11 EmperorYP7

@EmperorYP7 @divy9881 @noob20000405 @sheny1xuan

casbin-bot avatar Nov 21 '21 14:11 casbin-bot

@sheny1xuan

hsluoyz avatar Nov 21 '21 14:11 hsluoyz

Good point. But I think it's maybe difficult to do that automatically. Because if we update cmake file atfer a new release, we will generate change in cmakelists.txt. And I can't find a plugin can do that thing. Maybe we can update cmake version with the release rule. This is a very tricky thing. @EmperorYP7

sheny1xuan avatar Nov 22 '21 07:11 sheny1xuan

I'll keep everyone updated once I have a practical approach for this.

EmperorYP7 avatar Nov 24 '21 14:11 EmperorYP7