Fails to be visible on OS X in fullscreen mode

[alexchandel]

Whenever any app goes fullscreen, this subtitle player stays on the desktop. It needs to declare itself like a panel (see for example the Flux preferences pane), so it can hover over other fullscreen apps.

[carsonip]

@alexchandel I'll look into that soon. Good to know there's an example.

[alexchandel]

Another example is a fullscreen'd video from a web browser (e.g. Youtube on Chrome). The window occupies the entire screen on its own desktop, but the Penguin window cannot be dragged over it because macOS is treating it as a normal window rather than a panel window.

[ItsMeAubey]

As per #29 , it seems that fullscreen apps in macos block out the subtitle box.

The way to fix this seems simple as per https://stackoverflow.com/questions/40494297/how-to-show-qt-window-on-top-of-fullscreen-opened-window-on-osx,

The fix is changing "Qt.WindowStaysOnTopHint" to "Qt.Tool" in https://github.com/carsonip/Penguin-Subtitle-Player/blob/8829af6042561a91f7ac3f535578dd1bc19341f4/src/mainwindow.cpp#L48

[alexchandel]

@carsonip Could you please add an option in the settings to create the window with Qt::Tool instead of Qt::WindowStaysOnTopHint?

[carsonip]

I have experimented with Qt:Tool, and even with Qt::WA_MacAlwaysShowToolWindow, but the window will not display on top of a fullscreen app. Is it because the fullscreen window is on a new desktop? Still looking for a workaround.

[carsonip]

This may be relevant: https://stackoverflow.com/q/47711138