CareKit icon indicating copy to clipboard operation
CareKit copied to clipboard

Published 20 hours ago • verified publisher icon carekit-apple

feat: Add OCKHealthKitOutcome to OCKStore

Open cbaker6 opened this issue 3 years ago • 1 comments

  • [x] Renamed OCKObjectCompatible.swift -> OCKVersionedObjectCompatible.swift to match protocol name
  • [x] Made OCKHealthKitOutcome conform to OCKVersionedObjectCompatible
  • [x] Add OCKHealthKitOutcome to OCKEntity

cbaker6 avatar Jan 29 '22 17:01 cbaker6

@erik-apple I added some missing properties to OCKHealthKitOutcome. Though some of these aren't used currently, I made them match OCKOutcome as I suspect they will be needed in the future. I didn't physically add OCKHealthKitOutcome to CoreData as I'm guessing there may be another linkage along with more discussion to handle this properly.

I also marked some important properties as internal in the concrete OCK objects. I did this because I believe they were internal before the winter update and they probably shouldn't be manipulated by developers. Let me know if you need me to make some adjustments.

cbaker6 avatar Feb 03 '22 20:02 cbaker6