webamp icon indicating copy to clipboard operation
webamp copied to clipboard

Unpressed close button on eq is wrong

Open captbaritone opened this issue 6 years ago • 1 comments

https://twitter.com/winampskins/status/1170411431281352704

LuigiHann says:

772AC69F-672F-4CA0-B142-865D8248D95D

captbaritone avatar Sep 07 '19 22:09 captbaritone

Here's what Skinners Atlas has to say:

[Equalizer] Titlebar

This window has a titlebar and app-buttons too, and they are defined just like they were in titlebar.bmp. The long gray strips are the titlebar in active (top) and inactive (bottom) state. The close button inside the titlebars will be shown until you click on it, its pressed and unpressed states of the close button are painted between the background and the active titlebar, far left (unpressed is at top, pressed is at bottom). The winshade button is different, the pressed state is always the one shown in the painted in the titlebar, the unpressed state is defined in eq_ex.bmp (see later), if there is no eq_ex.bmp then it doesn't change when clicked.

I think the <ClickedDiv> component is what we need here.

Here's the bad CSS selector: https://github.com/captbaritone/webamp/blob/8e83d8e5c9247dc19fd7ed087d1d4a2a9967776a/js/skinSelectors.ts#L204

I'm not sure why this style only applies when the EQ window is selected. Maybe an error in my original CSS selector?

captbaritone avatar Sep 10 '19 15:09 captbaritone