webamp icon indicating copy to clipboard operation
webamp copied to clipboard

Published 20 hours ago • verified publisher icon captbaritone

Webcramp

Open 1j01 opened this issue 7 years ago • 5 comments

A little experiment adding Winamp v0.2a - a much simpler project :)

WIP PR so I can try out that Netlify magic and share a deploy

1j01 avatar May 06 '18 00:05 1j01

The deploy preview didn't work (sensibly), but here's a rawgit link since there's nothing fancy going on: https://rawgit.com/1j01/webamp/00f3db370f443040002d364e52099b5773005d36/experiments/webcramp/index.html

1j01 avatar May 06 '18 00:05 1j01

Branch-based link: https://github.com/1j01/webamp/blob/webcramp/experiments/webcramp/index.html

Functional now.

TODO

  • [ ] handle clicking disabled menu items (I made it trigger the action when clicking "disabled" menu items originally in jspaint because I couldn't actually detect whether copy/paste/cut were possible - probably should be enabled and not necessarily work rather than be disabled but actually maybe work, anyways)
  • [ ] make titlebars not suck
    • [ ] fix wrapping to multiple lines (fixed in 98.js i think, need to sync 98.js with os-gui and such)
    • [ ] titlebar buttons
    • [ ] padding
  • [ ] layout for the about window
  • [ ] add a footer to the page and link back to webamp
  • [ ] README
  • [ ] get linter happy and figure out deployment

1j01 avatar May 06 '18 02:05 1j01

@1j01 Love this! Curious how you want to work on it. Do you want to merge as is or do you want to get a few more things on that TODO list done before you merge?

captbaritone avatar May 15 '18 23:05 captbaritone

I was thinking I would do those things before merge. Most of these shouldn't be very hard, I just don't know when I'll work on it. The main thing is I want to sync up changes between os-gui and the projects that [should] use it and make it more of a proper library (so far I've just been copy pasting between projects, since before it was a separate project, and still so far now that it has its own repo)

1j01 avatar May 16 '18 04:05 1j01

Cool. No hurry. This is just a fun extra thing. I’ll leave the PR open until you find some time! 🙂

-- Jordan Eldredge (mobile)

On May 15, 2018, at 9:21 PM, Isaiah Odhner [email protected] wrote:

I was thinking I would do those things before merge. Most of these shouldn't be very hard, I just don't know when I'll work on it. The main thing is I want to sync up changes between os-gui and the projects that [should] use it and make it more of a proper library (so far I've just been copy pasting between projects, since before it was a separate project, and still so far now that it has its own repo)

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

captbaritone avatar May 16 '18 06:05 captbaritone