Jordan Eldredge
Jordan Eldredge
We don't have any hard blockers internally, but I don't have a known solution to working around the [Flow comment blocks](https://flow.org/en/docs/types/comments/). Maybe we need a separate feature flag to disable...
To enable this for tests you'll need to enable the feature flag here: https://github.com/facebook/relay/blob/3b9f90a2e1f4f1b4c9b0aa2a7597db48cb6be19f/compiler/crates/relay-typegen/tests/generate_typescript/mod.rs#L80
Looks like we'll also need to rebase.
I've asked internally about dealing with the Flow comments. Can you add some tests to see what happens with various types of descriptions? Specifically things like long lines and line...
I think we need a story for Flow here. I'm looking internally to see if maybe we can just drop the flow comment syntax.
Might be more correct to say "turn a global variable _reference_ into an explicit fragment argument". I'm imagining it would turn this: ```graphql fragment UserProfile_fragment on User { name profile_picture...
Thanks for the report and the followup. Should we be creating a different Watchman query here maybe? Or maybe just be more explicit (including validation) that we are expecting directories?
Looks like in the Rust code we are expecting directories here. Maybe we can add a runtime validation that ensures they are existing directories before creating the Watchman query? https://github.com/facebook/relay/blob/1a57f08326653b0803a8ecb26894895e4e6e1556/compiler/crates/relay-compiler/src/config.rs#L694
Still excited about this one. Feel free to ping when it's ready to review.
@JeffGuKang The source of truth for this content is here: https://github.com/facebook/relay/blob/main/website/docs/tutorial/queries-2.md