react-native-pathjs-charts
react-native-pathjs-charts copied to clipboard
Android Crash react-native-svg 4.5.0
Before filing an issue please ensure the following boxes are checked, if applicable:
- [x] I have searched for existing issues
- [x] I have provided detailed instructions that can reproduce the issue (including code and data necessary)
I realise you have given reasons to not update react-native-svg, but 4.5.0 crashes on Android all the time. I have a StockLine graph that updates every 5 seconds. I simply create a new array of 15 items that is attached to the data prop. Using react-native-svg 4.5.0 it will only work for around 2 minutes before crashing. react-native-community/react-native-svg#38 explains my problem exactly and a fix was released in 4.6.0.
I have manually changed the package dependency to 5.1.3 and I'm not suffering the same problems. Is it possible to re-consider upgrading the react-native-svg package as 4.5.0 is almost unusable for me.
This is nice feedback to have - I hadn't seen any downsides to sticking with 4.5.0 until now.
Unfortunately now, its a matter of picking from two imperfect options - if we go to 5.1.x, BarChart users of the react-native-pathsjs-charts library will be affected by this bug where text rotation is broken: https://github.com/react-native-community/react-native-svg/issues/242 while sticking with 4.5.0 negatively impacts users like you.
I'd love to hear ideas from other users of this library (what are your thoughts between these two options?), but for now, I'm inclined to stick with the versions we have and be ok with some users needing to manually upgrade to newer versions as you have done.
At some point it would be nice to dig in to the root cause of the text rotation bug in the react-native-svg library and offer a pull request for a fix to that bug in that project.
We can keep this issue open, look for feedback from others, and perhaps prioritize this higher later as circumstances warrant this.
Hey everyone, I'm working with a group of students and we're using this library because it seems like one of the graph libraries for React-Native least prone to randomly crashing. However, depending on the Android device we run it on, the rendering of graphs with this library also causes crashes on a regular basis. The log doesn't give any helpful information (or any information at all) when these crashes happen. I'm not sure if our issues are related to react-native-svg not being up to date or to something completely different, but if you have any tips on how to figure it out, it would be greatly appreciated. I'm dynamically re-rendering a 2-curves smooth line chart at the press of a button, with a new data set of up to 24 data points. Thanks for reading through!
@TommasoPieroncini This is similar to my findings. By changing the react-native-svg package dependency to 5.1.3, you can test whether it helps or not. As long as your not using BarChart you should see no problems with upgrading it anyway.
@marzolfb Have you tried with the latest version of react-native-svg? It now conforms to the spec regarding transforms and rotations (or it should at least, please tell me if you find bugs).