react-native-pathjs-charts icon indicating copy to clipboard operation
react-native-pathjs-charts copied to clipboard

code performance optimize

Open ghost opened this issue 8 years ago • 4 comments
trafficstars

hi, i met some scenario, such as drawing candle chart thanks to google search engine, let me know react-native-pathjs-charts so i try to search some demo for scenario(how to draw candle chart) sadly, i failed so i had to use your code to draw candle chart here is my github repository

image

ghost avatar Mar 14 '17 04:03 ghost

A candlestick chart type would be a great addition to this library. To get this chart into to this library, could you fork this project, add your changes, and then submit a pull request here?

Also, your issue title says "code performance optimize" - did you make any performance-improving changes or did you just add the new candlestick chart type?

marzolfb avatar Mar 15 '17 13:03 marzolfb

@marzolfb, I make some performance-improving changes for your code. For more details, you ought to check code. I add the new candlestick chart type(extends stackstick chart type)

ghost avatar Mar 16 '17 04:03 ghost

In checking the code, it would be extremely helpful if you used standard Github tooling to fork the project and submit a pull request. That way, I can easily see a diff between the current project and your work and we can collaborate on specific line by line changes you made.

marzolfb avatar Mar 16 '17 11:03 marzolfb

Ok, I am going to submit a pull request

ghost avatar Mar 16 '17 12:03 ghost