vscode-exports-autocomplete icon indicating copy to clipboard operation
vscode-exports-autocomplete copied to clipboard

Feature request: Support quote styles

Open doctyper opened this issue 8 years ago • 8 comments

Our style guide at work calls for double quotes, but there's currently no way to set this.

doctyper avatar Jan 09 '17 16:01 doctyper

for implementation, we should extract usesStandard and eslintCLI from uses-semi.js and use both to find the quote style (which btw could also be `!)

flying-sheep avatar Jan 09 '17 18:01 flying-sheep

Agreed, but I think you should allow a setting to override the check. I think it's better to be explicit than implicit.

doctyper avatar Jan 09 '17 18:01 doctyper

@capaj why the 😕 face?

flying-sheep avatar Jan 09 '17 19:01 flying-sheep

@flying-sheep who the hell uses backticks for import strings? that's just plain crazy 😈

capaj avatar Jan 09 '17 19:01 capaj

heh, i bet there’s somewhere out there. but it’s not hard to support. shall i make a PR?

flying-sheep avatar Jan 09 '17 19:01 flying-sheep

@flying-sheep I will add the config override. If you can, please extract that bit from uses-semi.js

capaj avatar Jan 09 '17 19:01 capaj

OK

flying-sheep avatar Jan 09 '17 19:01 flying-sheep

@doctyper 0.3.3 has been released with the config added. Feel free to try it out and let me know if you have any issues. I will leave this opened, because it would be nice to have the quote style set automagically for each project based on eslint settings.

capaj avatar Jan 09 '17 19:01 capaj