zeebe-simple-monitor icon indicating copy to clipboard operation
zeebe-simple-monitor copied to clipboard

implemented kafka support using new project zeebe-exporter-source

Open cameronbraid opened this issue 5 years ago • 3 comments
trafficstars

re-did https://github.com/zeebe-io/zeebe-simple-monitor/pull/183 based on a new project

https://github.com/cameronbraid/zeebe-exporter-source

Depends on zeebe-io/zeebe-kafka-exporter#35

Implemented integration test using kafka+protobuf

cameronbraid avatar Sep 16 '20 16:09 cameronbraid

This requires slight changes to the configuration

To enable hazelcast (this is the default configuration in src/main/resources/application.yaml

zeebe.exporter.source.hazelcast:
  enabled: true
  connection: localhost:5701
  connectionTimeout: PT30S

to enable kafka

zeebe.exporter.source.kafka:
  enabled: true
  format: protobuf
  consumerProperties: |
    bootstrap.servers=kafka:9093
    group.id=zeebe-simple-monitor
    auto.offset.reset=earliest

These configs will cause the conditional @Configuration classes to be imported

cameronbraid avatar Sep 16 '20 16:09 cameronbraid

@cameronbraid I like the idea of having one project that combines all exporter streams :+1: In the future, I would like to see support for the Hazelcast exporter JSON format and especially the ElasticSearch exporter :rocket:

Since the importing part is essential for the simple monitor and ZeeQS project, I would like to move your project zeebe-exporter-source into Zeebe's organization. This would allow us to build releases easily and contribute to it, even in your absence. You would still be the main contributor. Is this okay for you?

The code changes themselves look good so far. I would recommend to move the Kafka test to the zeebe-exporter-source project. So, we don't need to write such a test in all dependent projects, like the simple monitor or ZeeQS.

saig0 avatar Jan 06 '21 05:01 saig0

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Aug 26 '21 11:08 CLAassistant

Closing, because outdated.

nitram509 avatar Dec 11 '22 14:12 nitram509