rebolt-navigation icon indicating copy to clipboard operation
rebolt-navigation copied to clipboard

Published 20 hours ago • verified publisher icon callstackincubator

Add tests

Open grabbou opened this issue 7 years ago • 6 comments
trafficstars

What to test and how

grabbou avatar Mar 20 '18 13:03 grabbou

I started thinking how we can test

czystyl avatar May 02 '18 07:05 czystyl

@czystyl can you share your ideas? Looking forward to helping!

guilhermedecampo avatar May 09 '18 00:05 guilhermedecampo

here are some neat and simple examples: https://github.com/jthegedus/reasonml

@guilhermedecampo that would be awesome!

knowbody avatar May 09 '18 08:05 knowbody

@knowbody I did the same on my branch - that is simple jest tests. @guilhermedecampo You can check branch test/init there is some initial setup for tests.

What issues in on test/init branch:

  • The test code needs to be compiled before jest command: ReasonMl -> js -> jest. It not a good DX.
  • needs to figurate how to render Reason component inside tests and create the snapshots. Check what is wrong with snapshots here: https://reasonml.chat/t/snapshot-testing-a-reasonreact-component/249

czystyl avatar May 09 '18 19:05 czystyl

thank you guys! Checking soon.

guilhermedecampo avatar May 09 '18 21:05 guilhermedecampo

ok changing the topic of this, let's add, instead of just thinking about tests ;p

@czysty if you have anything, please send a WIP PR so we can start with something and then we'll improve it

knowbody avatar May 27 '18 07:05 knowbody