react-native-slider icon indicating copy to clipboard operation
react-native-slider copied to clipboard

The slider stopped working

Open valery-lavrik opened this issue 3 years ago • 4 comments

Hello everyone The slider has been working on the project for a long time, everything is fine with it. But, today I tried to add to the project yarn add valery-lavrik/react-native-fast-image

how the app immediately stopped working. The slider now throws an error: image

After I deleted valery-lavrik/react-native-fast-image, the slider didn't work anymore.
I tried: rm -rf node_modules ./gradlew clean rm -rf android/.gradle restarting the computer

nothing helps.

  1. How to restore the application now
  2. what exactly in the valery-lavrik/react-native-fast-image package broke the slider?

valery-lavrik avatar Aug 11 '22 10:08 valery-lavrik

Yes, this was introduced with the 4.3.0 version and it's a side effect of react-native-gradle-plugin fetched for Android. We are currently working on it in #414. However, I've tried to find the valery-lavrik/react-native-fast-image you mention, but I don't see it anywhere, so I can't even check which version is used in this package. Can you give me the direct link to it?

BartoszKlonowski avatar Aug 11 '22 11:08 BartoszKlonowski

@BartoszKlonowski
https://github.com/valery-lavrik/react-native-fast-image

valery-lavrik avatar Aug 11 '22 11:08 valery-lavrik

@valery-lavrik I'm sorry, I thought you are using some external package, not yours internal one. What I don't understand in the steps you provided is

After I deleted valery-lavrik/react-native-fast-image, the slider didn't work anymore.

what exactly were the steps here?

BartoszKlonowski avatar Aug 11 '22 11:08 BartoszKlonowski

@BartoszKlonowski
I found a solution: "@react-native-community/slider": "4.2.4", (removed the ^ symbol)

And it didn't work for me because after deleting the package I did yarn, which always puts the latest version (in the case of the browser - 4.3.0) And I used to do npm i which installs packages a little differently

valery-lavrik avatar Aug 11 '22 11:08 valery-lavrik

@valery-lavrik OK, thank you! I found a root cause and I'll work on the fix - as this issue is a duplicated item of #415 please track the progress there. I will close this as a duplicate but I'll post here also when hotfix is released.

BartoszKlonowski avatar Aug 12 '22 21:08 BartoszKlonowski

@valery-lavrik The fix is now released in v4.3.1

BartoszKlonowski avatar Aug 20 '22 11:08 BartoszKlonowski