react-native-paper icon indicating copy to clipboard operation
react-native-paper copied to clipboard

feat: bumped React Native and Expo version

Open kamilkedzierski opened this issue 1 year ago • 3 comments

Motivation

We needed to bump the Android SDK version (see the attached screenshot for details). To accommodate this, we also had to update React Native and Expo, as the versions we were using were outdated and no longer supported.

Summary:

Version Updates:

Issues Encountered & Resolved:

  • Icons were not displaying on the web.
  • Some test cases failed.
  • Assets from the react-native-paper library were not displaying in the example project.

All issues were resolved after the updates.

Related issue

image

Test plan

I would appreciate it if the reviewer could double-check the example app to ensure that no bugs were missed during the update. 🙏

kamilkedzierski avatar Aug 13 '24 20:08 kamilkedzierski

Hey @kamilkedzierski, thank you for your pull request 🤗. The documentation from this branch can be viewed here.

callstack-bot avatar Aug 14 '24 11:08 callstack-bot

This looks good, I only found 2 issues. FAB on web doesn't look good, but I think it is a known issue. floatingActionButton_web

What I think it is from this PR, is on iOS when switching to RTL, the app restarts infinitely.

https://github.com/user-attachments/assets/35aec213-8267-44a8-b30e-608aaddf1874

Can we fix that?

gedu avatar Sep 28 '24 18:09 gedu

This looks good, I only found 2 issues. FAB on web doesn't look good, but I think it is a known issue. floatingActionButton_web

What I think it is from this PR, is on iOS when switching to RTL, the app restarts infinitely.

Screen.Recording.2024-09-28.at.19.52.15.mp4 Can we fix that?

Here is the FAB issue for future reference.

iM-GeeKy avatar Oct 15 '24 09:10 iM-GeeKy

RTL update LGTM

gedu avatar Nov 28 '24 14:11 gedu